chore: add tests

dzgui/model/servers.py

@@ -201,43 +201,19 @@ class ServerModelManager:
 
     @call_on_thread(dialog.querying)
     def add_by_ip(self, addr: str) -> None:
-        self.preserve_on_fail = True
-        try:
-            res = Servers.query_by_ip(addr)
-            self._parse_single_record(res)
-        except Exception as e:
-            logger.warning(e)
-            self.thread_man.set_cleanup_func(
-                StoredFunc(self._cleanup_on_failure), destroy_first=True
-            )
-            return
+        res = Servers.query_by_ip(addr)
+        self._parse_single_record(res)
 
     @call_on_thread(dialog.querying)
     def add_by_record(self, record: Servers.Record) -> None:
-        self.preserve_on_fail = True
         # NOTE: rationale: a raw Record as shown in server browser may resolve to a different IP
-        try:
-            res = Servers.query_by_record(record)
-            self._parse_single_record(res)
-        except Exception as e:
-            logger.warning(e)
-            self.thread_man.set_cleanup_func(
-                StoredFunc(self._cleanup_on_failure), destroy_first=True
-            )
-            return
+        res = Servers.query_by_record(record)
+        self._parse_single_record(res)
 
     @call_on_thread(dialog.querying)
     def remove_by_record(self, record: Servers.Record) -> None:
-        self.preserve_on_fail = True
-        try:
-            res = Servers.query_by_record(record)
-            self._parse_single_record(res, delete=True)
-        except Exception as e:
-            logger.warning(e)
-            self.thread_man.set_cleanup_func(
-                StoredFunc(self._cleanup_on_failure), destroy_first=True
-            )
-            return
+        res = Servers.query_by_record(record)
+        self._parse_single_record(res, delete=True)
 
     def update_history(
         self,
@@ -304,6 +280,7 @@ class ServerModelManager:
         proxy_man.update_playercount(self.playercount)
 
     def _parse_single_record(self, response: "A2SInfo", delete: bool = False) -> None:
+        self.preserve_on_fail = True
         try:
             row = response.as_row()
         except Exception as e:

tests/test_list_store.py

@@ -0,0 +1,47 @@
+import pytest
+
+from dzgui.model.model_factory import FastInsertListStore
+
+
+@pytest.fixture
+def heterogeneous_list() -> None:
+    return [["a", 0, True], ["b", 1, False]]
+
+
+@pytest.fixture
+def mismatched_length_list() -> None:
+    return [["a", 0, True], ["b", 1, False, 0]]
+
+
+@pytest.fixture
+def extended_list(heterogeneous_list) -> None:
+    fs = FastInsertListStore(str, int, bool)
+    fs.extend(heterogeneous_list)
+    return fs
+
+
+@pytest.fixture
+def appended_list(heterogeneous_list) -> None:
+    fs = FastInsertListStore(str, int, bool)
+    for row in heterogeneous_list:
+        fs.append(row)
+    return fs
+
+
+@pytest.mark.parametrize("target", ["extended_list", "appended_list"])
+def test_list_parity(heterogeneous_list, request, target) -> None:
+    target = request.getfixturevalue(target)
+    extracted = [[el for el in row] for row in target]
+    assert heterogeneous_list == extracted
+
+
+def test_type_disparity(heterogeneous_list) -> None:
+    with pytest.raises(TypeError):
+        fs = FastInsertListStore(str, bool, bool)
+        fs.extend(heterogeneous_list)
+
+
+def test_length_disparity(mismatched_length_list) -> None:
+    with pytest.raises(ValueError):
+        fs = FastInsertListStore(str, int, bool)
+        fs.extend(mismatched_length_list)