From eed40e6f1a91702b31244667e7b0496dea51402b Mon Sep 17 00:00:00 2001 From: aclist <92275929+aclist@users.noreply.github.com> Date: Wed, 21 Oct 2026 12:59:54 +0900 Subject: [PATCH] change: return client name from controller --- dzgui/controllers/mc.py | 5 +++++ dzgui/managers/connection.py | 3 +-- tests/test_client_name.py | 19 +++++++++++++++++++ 3 files changed, 25 insertions(+), 2 deletions(-) create mode 100644 tests/test_client_name.py diff --git a/dzgui/controllers/mc.py b/dzgui/controllers/mc.py index 8267777..afc1cba 100644 --- a/dzgui/controllers/mc.py +++ b/dzgui/controllers/mc.py @@ -541,6 +541,11 @@ class Controller(GObject.GObject): def update_status(self) -> None: self.mediator.preconnect.mark_finished() + def get_client_name(self) -> str: + # NOTE: only possible values are "Steam" and "Flatpak" + cmd = self.query_config(Preferences.CLIENT) + return cmd.split()[0].capitalize() + def present_window(self) -> None: self.mediator.window.present_with_time(Gdk.CURRENT_TIME) diff --git a/dzgui/managers/connection.py b/dzgui/managers/connection.py index 1089b4c..574f622 100644 --- a/dzgui/managers/connection.py +++ b/dzgui/managers/connection.py @@ -185,8 +185,7 @@ class ConnectionManager: allows_downloads = (True, "") client = self.controller.query_config(Preferences.CLIENT) - # TODO: add test - client_name = client.split()[0].capitalize() + client_name = self.controller.get_client_name() running = is_steam_running(client) steam_proc = SteamProcess(client_name, running) self.client = client diff --git a/tests/test_client_name.py b/tests/test_client_name.py new file mode 100644 index 0000000..27f81fc --- /dev/null +++ b/tests/test_client_name.py @@ -0,0 +1,19 @@ +import pytest + +from dzgui.const.constants import FLATPAK_RUN_CMD, STEAM_CMD +from dzgui.controllers.mc import Controller + + +@pytest.mark.parametrize( + "value, expected", [(FLATPAK_RUN_CMD, "Flatpak"), (STEAM_CMD, "Steam")] +) +def test_human_name(monkeypatch, value, expected) -> None: + def mock_query_config(*args) -> str: + return value + + monkeypatch.setattr( + "dzgui.controllers.mc.Controller.query_config", mock_query_config + ) + controller = Controller() + client = controller.get_client_name() + assert client == expected