From 7139686d9bc7c4211c96131e6dd561027302871e Mon Sep 17 00:00:00 2001
From: aclist <92275929+aclist@users.noreply.github.com>
Date: Fri, 1 May 2026 23:59:27 +0900
Subject: [PATCH] chore: store filter levels as constant

---
 dzgui/const/constants.py      |  2 ++
 dzgui/views/pages/log.py      | 18 ++++++++----------
 dzgui/views/trees/tree_log.py |  6 ++----
 3 files changed, 12 insertions(+), 14 deletions(-)

diff --git a/dzgui/const/constants.py b/dzgui/const/constants.py
index ed3f578..105fcc5 100644
--- a/dzgui/const/constants.py
+++ b/dzgui/const/constants.py
@@ -61,3 +61,5 @@ LEGACY_IPS_PATH = ".local/share/dzgui/helpers/ips.csv"
 DEBUG_LOG = f"{APP_NAME}_DEBUG.LOG"
 SYSTEM_LOG = f"{APP_NAME}_SYSTEM.LOG"
 CHANGELOG_PATH = "data/CHANGELOG.md"
+
+LOG_FILTERS = ("CRITICAL", "WARNING", "INFO", "DEBUG")
diff --git a/dzgui/views/pages/log.py b/dzgui/views/pages/log.py
index 50271ae..b9fbc3b 100644
--- a/dzgui/views/pages/log.py
+++ b/dzgui/views/pages/log.py
@@ -1,4 +1,5 @@
 from typing import TYPE_CHECKING
+from dzgui.const.constants import LOG_FILTERS
 from dzgui.views.mixins.cursor_mixin import CursorMixin
 from dzgui.views.mixins.help_menu_mixin import HelpMenuMixin
 from dzgui.views.trees.tree_log import LogTreeView
@@ -16,23 +17,20 @@ if TYPE_CHECKING:
 class Log(CursorMixin, HelpMenuMixin, Gtk.Box):  # type: ignore
     def __init__(self, controller: "Controller") -> None:
         super().__init__(orientation=Gtk.Orientation.VERTICAL)
-        # NOTE: LogTreeView is kept in a separate ScrolledWindow so that
-        # checkboxes will be flush on bottom
+        """
+        NOTE: LogTreeView is kept in a separate ScrolledWindow so that
+        checkboxes will be flush on bottom
+        """
         self.scrolled = Gtk.ScrolledWindow()
         self.treeview = LogTreeView(controller)
         self.scrolled.add(self.treeview)
 
         self.check_bar = Gtk.Box(orientation=Gtk.Orientation.HORIZONTAL)
-        # TODO: strings
-        active = (
-            "WARN",
-            "CRITICAL",
-        )
-        for check in ("WARN", "CRITICAL", "INFO", "DEBUG"):
+
+        for check in LOG_FILTERS:
             c = Gtk.CheckButton(label=check)
             self.check_bar.pack_start(c, False, False, 0)
-            if check in active:
-                c.set_active(True)
+            c.set_active(True)
             c.connect("clicked", self._on_checkbox_clicked)
         self.add(self.scrolled)
         self.add(self.check_bar)
diff --git a/dzgui/views/trees/tree_log.py b/dzgui/views/trees/tree_log.py
index 30174c0..2340d59 100644
--- a/dzgui/views/trees/tree_log.py
+++ b/dzgui/views/trees/tree_log.py
@@ -2,7 +2,7 @@ import logging
 
 from typing import Any, TYPE_CHECKING
 
-from dzgui.const.constants import APP_NAME
+from dzgui.const.constants import APP_NAME, LOG_FILTERS
 from dzgui.const.enum import ContextMenuGroup
 from dzgui.model.model_factory import ModelFactory
 from dzgui.util import strings
@@ -35,9 +35,7 @@ class LogTreeView(ContextMixin, TreeView):
 
         self.set_model(None)
 
-        # TODO: strings
-        # NOTE: default filters that should be shown on startup
-        self.filters = ["CRITICAL", "WARNING"]
+        self.filters = list(LOG_FILTERS)
         for i, column_title in enumerate(strings.log_cols):
             renderer = Gtk.CellRendererText()
             column = Gtk.TreeViewColumn(column_title, renderer, text=i)