From 1a1145c79cd176cb500dea4b819f73c3d25fe9ef Mon Sep 17 00:00:00 2001
From: aclist <92275929+aclist@users.noreply.github.com>
Date: Sun, 16 Aug 2026 12:56:49 +0900
Subject: [PATCH] chore: clear typehinting errors

---
 dzgui/views/components/buttons.py | 2 +-
 dzgui/views/pages/offline.py      | 6 +++---
 dzgui/views/pages/options.py      | 7 +++++--
 3 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/dzgui/views/components/buttons.py b/dzgui/views/components/buttons.py
index 6697c17..45df27d 100644
--- a/dzgui/views/components/buttons.py
+++ b/dzgui/views/components/buttons.py
@@ -288,7 +288,7 @@ class SpinnerButton(Gtk.Button):
         self.connect("clicked", self._on_button_clicked)
         self.connect("map", self._on_map)
 
-    def _on_map(self, a) -> None:
+    def _on_map(self, button: Self) -> None:
         self.spinner.set_visible(False)
 
     def _on_button_clicked(self, button: Self) -> None:
diff --git a/dzgui/views/pages/offline.py b/dzgui/views/pages/offline.py
index dec7060..b0200b0 100644
--- a/dzgui/views/pages/offline.py
+++ b/dzgui/views/pages/offline.py
@@ -61,7 +61,7 @@ class OfflineErrorPopover(ErrorPopover):
     def __init__(self, relative_to: Gtk.Widget, position: Gtk.PositionType) -> None:
         super().__init__(relative_to=relative_to, position=position)
 
-    def set_label(self, error: FolderError, msg: str) -> None:
+    def set_error_label(self, error: FolderError, msg: str) -> None:
         match error:
             case FolderError.NO_VALID_MODS:
                 prefix = offline.no_mods
@@ -159,13 +159,13 @@ class FolderHBox(HBox):
 
     def present_error(self, error: FolderError, msg: str) -> None:
         if error == FolderError.FOLDER_CHANGED:
-            self.sidepop.set_label(error, msg)
+            self.sidepop.set_error_label(error, msg)
             self.sidepop.popup()
             return
         self.folder = ""
         self.label.set_text("")
         self.unset_button.hide()
-        self.pop.set_label(error, msg)
+        self.pop.set_error_label(error, msg)
         self.pop.popup()
 
 
diff --git a/dzgui/views/pages/options.py b/dzgui/views/pages/options.py
index a0748fc..0066a6a 100644
--- a/dzgui/views/pages/options.py
+++ b/dzgui/views/pages/options.py
@@ -69,6 +69,7 @@ class SubmitField(Gtk.Box):
             self.entry.connect("icon-release", self._on_icon_release)
             self.entry.set_visibility(False)
 
+        self.button: SpinnerButton | Gtk.Button
         if slow:
             self.button = SpinnerButton(label=options.save_button)
         else:
@@ -183,12 +184,14 @@ class SteamSubmitField(SubmitField):
 
     def _on_api_success(self, emitter: "Emitter") -> None:
         self.old_text = self.entry.get_text()
-        self.button.stop_spinner()
+        if isinstance(self.button, SpinnerButton):
+            self.button.stop_spinner()
         self.entry.set_sensitive(True)
 
     def _on_api_failure(self, emitter: "Emitter") -> None:
         self.pop.popup()
-        self.button.stop_spinner()
+        if isinstance(self.button, SpinnerButton):
+            self.button.stop_spinner()
         self.entry.set_sensitive(True)
 
     def block_text_entry(self) -> None: